Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix init and close of logs stream #304

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

MUzairS15
Copy link

Description

The log stream once created was not getting closed causing issues when the user again tried to stream logs for the same pod.
The PR ensure the log stream is appropriately closed when 'stop' signal is received.
Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 9.35%. Comparing base (a8e2fb7) to head (8394632).
Report is 7 commits behind head on master.

Files Patch % Lines
meshsync/logstream.go 0.00% 8 Missing ⚠️
internal/config/crd_config.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #304      +/-   ##
=========================================
- Coverage    9.37%   9.35%   -0.02%     
=========================================
  Files          10      10              
  Lines         651     652       +1     
=========================================
  Hits           61      61              
- Misses        583     584       +1     
  Partials        7       7              
Flag Coverage Δ
unittests 9.35% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MUzairS15 MUzairS15 merged commit 8ac2bd6 into master Mar 1, 2024
4 of 6 checks passed
@MUzairS15 MUzairS15 deleted the MUzairS15/fix/log-session branch March 1, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant