fix: Add SDK keyword for all Airbyte wrapper plugins #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenFrankel
requested review from
sbalnojan,
tayloramurphy and
pnadolny13
as code owners
✅ Deploy Preview for meltano-hub ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pnadolny13
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
@ReubenFrankel thanks for this! It is a little weird that its both built with airbyte and meltano but its actually correct and it adds back the default SDK setting for these.
|
@pnadolny13 Yeah, I had the same thoughts and arrived at the same conclusion that you did. 🙂 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Airbyte wrapper plugin is built with the SDK and exposes SDK settings - it would therefore benefit from #1709.