Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use presence of meltano_sdk keyword to display SDK settings #1709

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Use presence of meltano_sdk keyword to display SDK settings #1709

merged 5 commits into from
Mar 20, 2024

Conversation

ReubenFrankel
Copy link
Contributor

From #1706:

I wasnt able to get the check for the meltano_sdk keyword to work for some reason. Someone else can give it a shot but keywords was always coming through empty for me

cc @pnadolny13 is this what you had in mind?

Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for meltano-hub ready!

Name Link
🔨 Latest commit baa841a
🔍 Latest deploy log https://app.netlify.com/sites/meltano-hub/deploys/65fae8f73af4d000082b6a8b
😎 Deploy Preview https://deploy-preview-1709--meltano-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@pnadolny13 pnadolny13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ReubenFrankel looks good to me! Thanks for the PR

@pnadolny13 pnadolny13 merged commit 427f15b into meltano:main Mar 20, 2024
10 checks passed
@ReubenFrankel ReubenFrankel deleted the sdk-settings-keyword branch March 20, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants