-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Significant Overhaul of the Interpreter's Timing Model #2235
Draft
Jaklyy
wants to merge
369
commits into
melonDS-emu:master
Choose a base branch
from
Jaklyy:chemical-x2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably wrong
idk what's happening fully and its gonna be slow to emulate most likely we'll figure this out later
kinda slow though?
i cannot comprehend what is happening currently
now with actual testing to back them up!
Also add a (probably not fully correct) 4 cycle delay across the board. Should improve the timing of when IRQs are noticed by the CPU a fair bit?
This reverts commit cc9a6f8.
idk what i just wrote tbh
my bad!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavily reworks the ARM9 & ARM7 timing models to greatly improve accuracy (and slaughter performance).
Builds upon my work in #2125 and uses the excellent cache implementation found in #1955 (probably want to merge those two first). (hopefully building this pr upon those two doesn't cause any stupid or weird issues with git...? Fingers crossed?)
Implements:
Known Issues:
Main RAM DMA Timings are slightly worse for long DMAs.ARM7 DMA has yet to be touched.Nothing is included in savestates yet, so they may be a little broken.The ARM9 should trigger IRQs after code fetches and interlocks, and before instructions are executed. Currently I'm handling them before code fetches to make interlocks simpler to handle...