Fix: PG::NotNullViolation (MAYBE-RAILS-CG)

[revise-dev]

The error occurs because the uncategorized class method creates a new BudgetCategory instance without providing required values for budgeted_spending and currency, which are defined as NOT NULL in the database schema. This likely occurs when the application needs to handle transactions or budget items that don't have a specific category assigned.

The original intent of the uncategorized method was to create a special BudgetCategory instance with a UUID generated from the string "uncategorized" and no associated category. However, it didn't account for the database constraints requiring budgeted_spending and currency values.

Changes made:

1. Added budgeted_spending: 0 to provide a sensible default for uncategorized items
2. Added currency: budget&.currency || "USD" to inherit the currency from the associated budget if available, falling back to USD
3. Made the method accept an optional budget parameter to properly set the currency

The changes maintain the original functionality while ensuring database constraints are met. The default value of 0 for budgeted_spending makes sense since uncategorized items typically don't have a planned budget.

Tests should be added to verify:

1. The uncategorized method creates a valid BudgetCategory
2. The currency is inherited from the budget when provided
3. The currency falls back to USD when no budget is provided
4. The budgeted_spending is set to 0

Tip

You can make revisions or ask questions of Revise.dev by using /revise in any comment or review!

• /revise Add a comment above the method to explain why we're making this change.
• /revise Why did you choose to make this change specifically?

Important

If something doesn't look right, click to retry this interaction.