Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Decimal Support in min transaction #1681

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −5
Open

Added Decimal Support in min transaction #1681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
925b66e
Added Decimal Support in min transaction
Harry-kp Jan 24, 2025
57b2ea5
fix: Using inbuilt money field
Harry-kp Jan 25, 2025
b343cdb
Updated Test
Harry-kp Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/views/credit_cards/_form.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,11 @@
</div>

<div class="flex items-center gap-2">
<%= credit_card_form.number_field :minimum_payment,
<%= credit_card_form.money_field :minimum_payment,
label: t("credit_cards.form.minimum_payment"),
placeholder: t("credit_cards.form.minimum_payment_placeholder"),
min: 0 %>
default_currency: Current.family.currency %>

<%= credit_card_form.number_field :apr,
label: t("credit_cards.form.apr"),
placeholder: t("credit_cards.form.apr_placeholder"),
Expand Down
4 changes: 2 additions & 2 deletions test/controllers/credit_cards_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class CreditCardsControllerTest < ActionDispatch::IntegrationTest
accountable_type: "CreditCard",
accountable_attributes: {
available_credit: 5000,
minimum_payment: 25,
minimum_payment: 25.51,
apr: 15.99,
expiration_date: 2.years.from_now.to_date,
annual_fee: 99
Expand All @@ -36,7 +36,7 @@ class CreditCardsControllerTest < ActionDispatch::IntegrationTest
assert_equal 1000, created_account.balance
assert_equal "USD", created_account.currency
assert_equal 5000, created_account.accountable.available_credit
assert_equal 25, created_account.accountable.minimum_payment
assert_equal 25.51, created_account.accountable.minimum_payment
assert_equal 15.99, created_account.accountable.apr
assert_equal 2.years.from_now.to_date, created_account.accountable.expiration_date
assert_equal 99, created_account.accountable.annual_fee
Expand Down
2 changes: 1 addition & 1 deletion test/system/accounts_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class AccountsTest < ApplicationSystemTestCase
test "can create credit card account" do
assert_account_created "CreditCard" do
fill_in "Available credit", with: 1000
fill_in "Minimum payment", with: 25
fill_in "account[accountable_attributes][minimum_payment]", with: 25.51
fill_in "APR", with: 15.25
fill_in "Expiration date", with: 1.year.from_now.to_date
fill_in "Annual fee", with: 100
Expand Down
Loading