Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Glitch Modal with Coverscreen Prop #341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rifansyah
Copy link

[Fix: Glitch Modal with Coverscreen Prop]

What is going on?

Our modal (ex: BreakTimeModal) sometimes glitches after closed if we use coverScreen props.

This glitch is mostly happen in ios

Level: {medium}
the glitch makes our app looks unstable for the user.

How to reproduce?

Condition

  • using coverScreen props
  • modal with heavy content

Step

  • open modal
  • close modal

Caused by

this glitch doesn't only happen in modalbox library, but also react-native-modal (issue #1, #2) then fixed by this PR by peteroid. in the other hand, react-native-modalbox seems haven't fixed it yet.

if we refer to those issues, the glitch happens because the modal content is too complex for post-animation process.

Resolved by

we tried to fork react-native-modalbox and do same thing as the PR by peteroid in react-native-modal.

the main idea is to hide/not render the content right after the animation is complete. in that way, the modal has no complex content at all to cause the glitch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant