Fix: Glitch Modal with Coverscreen Prop #341
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fix: Glitch Modal with Coverscreen Prop]
What is going on?
Our modal (ex: BreakTimeModal) sometimes glitches after closed if we use coverScreen props.
This glitch is mostly happen in ios
Level: {medium}
the glitch makes our app looks unstable for the user.
How to reproduce?
Condition
Step
Caused by
this glitch doesn't only happen in modalbox library, but also react-native-modal (issue #1, #2) then fixed by this PR by peteroid. in the other hand, react-native-modalbox seems haven't fixed it yet.
if we refer to those issues, the glitch happens because the modal content is too complex for post-animation process.
Resolved by
we tried to fork react-native-modalbox and do same thing as the PR by peteroid in react-native-modal.
the main idea is to hide/not render the content right after the animation is complete. in that way, the modal has no complex content at all to cause the glitch