Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(insight, ad-ldap and user groups): added test cases #19

Merged
merged 5 commits into from
Nov 25, 2022

Conversation

furqanmlk
Copy link
Contributor

@furqanmlk furqanmlk commented Nov 23, 2022

@gitpod-io
Copy link

gitpod-io bot commented Nov 23, 2022

Copy link
Collaborator

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try deno task validate locally it should suggest folder names

data/test-cases/suite/ad-ldap/MM-test-case-1.md Outdated Show resolved Hide resolved
@saturninoabril saturninoabril changed the title test(insight, ad-ldap and user groups) added test cases test(insight, ad-ldap and user groups): added test cases Nov 24, 2022
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @furqanmlk for adding test cases! LGTM. Left several comments but mostly formatting, typo, etc.

Copy link
Collaborator

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @furqanmlk!

@saturninoabril saturninoabril added the 3: Reviews Complete All reviewers have approved the pull request label Nov 25, 2022
@saturninoabril saturninoabril merged commit 87a4dd4 into main Nov 25, 2022
@saturninoabril saturninoabril deleted the test_cases_added branch November 25, 2022 02:27
@saturninoabril
Copy link
Member

@furqanmlk, test cases saved - ebabb55. Note that I've manually changed the invalid Location value for it's not present in Zephyr. Currently, we're not saving anything to Zephyr whenever there's new custom field. Instead, it should be created and managed in the Zephyr's UI itself. I've created #25 to add validation.

Also, I changed folder name from "user-groups" to "User Groups" for consistency.

lindalumitchell pushed a commit that referenced this pull request Feb 15, 2024
…ugin. (#19) (#143)

* [MI-3804]: Added the test cases for the UI design on MS Teams sync plugin.

* [MI-3804]: added the test case for disconnected user with linked channels.

* [MI-3804]:Added the changes.

* [MI-3804]: added the changes for disconnecting user.

* [MI-3804]: Fixed the commetns by Aayush on the test cases.

* [MI-3804]: Fixed the comments.

* [MI-3804]: fixed the comments by Ayush.

* changed the test case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants