Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-62232] Update loading and welcome screens, theming fixes #3279

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[MM-62232] Update loading and welcome screens, theming fixes #3279

wants to merge 3 commits into from

Conversation

devinbinnie
Copy link
Member

Summary

This PR updates the loading and welcome screens with new graphics and theming.

To make dev review easier, I've broken this change into 2 commits:

  • First one is to simply replace the images with SVG components that can be themed using CSS variables, as well as replace the backgrounds with ones described by CSS. Old files have been removed.
  • Second one adds the Denim/Onyx theme variables to the Desktop App, and reworks a lot of the theming choices and fixes a few issues that prevented correct display of the new screens. A lot of the extra darkMode functionality is removed and replaced with simply changing CSS variables at the root component.

For UX review, instead of screenshots please use the test build available on the checks for this PR.

Ticket Link

https://mattermost.atlassian.net/browse/MM-62232

Refreshed loading and welcome screens.

@devinbinnie devinbinnie added 2: Dev Review Requires review by a core committer 1: UX Review Requires review by a UX Designer labels Jan 9, 2025
@devinbinnie devinbinnie added this to the v5.11.0 milestone Jan 9, 2025
@devinbinnie devinbinnie requested review from matthewbirtch, Rajat-Dabade and a team January 9, 2025 16:39
@devinbinnie devinbinnie added Build Apps for PR Builds signed builds for testing and removed release-note labels Jan 9, 2025
@devinbinnie devinbinnie requested review from a team, Rajat-Dabade and marianunez and removed request for Rajat-Dabade and a team January 9, 2025 16:40
@marianunez marianunez requested review from pvev and removed request for Rajat-Dabade January 9, 2025 16:43
marianunez
marianunez approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devinbinnie!

@devinbinnie
Copy link
Member Author

/update-branch

@devinbinnie devinbinnie added Build Apps for PR Builds signed builds for testing and removed Build Apps for PR Builds signed builds for testing labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marianunez marianunez marianunez approved these changes

@matthewbirtch matthewbirtch Awaiting requested review from matthewbirtch

@pvev pvev Awaiting requested review from pvev

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
1: UX Review Requires review by a UX Designer 2: Dev Review Requires review by a core committer Build Apps for PR Builds signed builds for testing release-note
Projects
None yet
Milestone
v5.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@devinbinnie @marianunez @mm-cloud-bot @mattermost-build