Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to allow x-signing key upload without UIA #1383

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jun 10, 2024

Per MSC3967, which is now stable, we should not require UIA when uploading cross-signing keys for the first time.

Synapse PR: element-hq/synapse#17284

@richvdh richvdh requested a review from a team as a code owner June 10, 2024 12:35
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the tests pass.

Re: the tests failing on Dendrite, it's probably best to blacklist the failing tests for Dendrite for now, unless you're keen to PR some go.

@richvdh
Copy link
Member Author

richvdh commented Jun 11, 2024

matrix-org/dendrite#3384 updates the Dendrite test whitelist.

devonh pushed a commit to matrix-org/dendrite that referenced this pull request Jun 13, 2024
matrix-org/sytest#1383 updates some sytests in
line with MSC3967. Dendrite does not support MSC3967, so these tests
fail.
@richvdh richvdh merged commit 2d5e02f into develop Jun 14, 2024
9 checks passed
@richvdh richvdh deleted the rav/stable_msc3967 branch June 14, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants