-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CORP headers to media repo #1197
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bd66aa1
Add CORP headers to media repo
turt2live f87e751
Merge branch 'main' into travis/corp-headers
turt2live 9fb8cca
Write weird CSS rules to make added-in work inline in the CS spec
turt2live f798a72
Remove test paragraph
turt2live 5236968
Refine prose
turt2live 8ac83c2
spelling is key
turt2live File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Add `Cross-Origin-Resource-Policy` (CORP) headers to media repository, as per [MSC3828](https://github.com/matrix-org/matrix-spec-proposals/pull/3828). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
{{/* | ||
|
||
"Temporary" shortcode for rendering paragraphs which want/need inline added-in tags. It is | ||
assumed that your content is described as follows: | ||
|
||
{{% boxes/added-in-paragraph %}} | ||
{{< added-in v="1.4" >}} Your text here | ||
|
||
{{< added-in v="1.4" >}} Your other text here | ||
{{% /boxes/added-in-paragraph %}} | ||
|
||
The assumption is that at a later date this added-in-paragraph shortcode can be removed, making | ||
the angle bracket-defined added-in shortcodes *just work*. | ||
|
||
It is important that each new "content" paragraph (the bit after added-in) is preceded with | ||
and added-in, otherwise you might find your text being weirdly merged. | ||
|
||
This exists while the added-in shortcode cannot be inline in the client-server spec. | ||
See https://github.com/matrix-org/matrix-spec/issues/1204 | ||
|
||
*/}} | ||
{{ partial "alert" (dict "type" "added-in-paragraph" "content" .Inner) }} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as mentioned in the commit: we don't need the complexity of 2+ paragraphs yet, but it's good behaviour to have for when we need it in the future.