Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC3860: Media Download Redirects #3860

Merged
merged 16 commits into from
May 9, 2023
+61 −0
Merged

MSC3860: Media Download Redirects #3860

Changes from 5 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ce59930
Add media download redirect proposal
Fizzadar Aug 4, 2022
964c19e
Add urls
Fizzadar Aug 4, 2022
088789b
Rename
Fizzadar Aug 4, 2022
916e1b3
Wrap content
Fizzadar Aug 17, 2022
9807bf4
Add note about MSC proposal and implementation work
Fizzadar Aug 17, 2022
6746c86
Add missing sections to MSC
Fizzadar Aug 23, 2022
6767a51
Rework to be opt-in via query param
Fizzadar Oct 21, 2022
aa14401
Fix typos
sumnerevans Mar 29, 2023
c9896a9
Clarify security considerations
sumnerevans Mar 29, 2023
4b61481
Clarify that unstable prefix should be used
sumnerevans Mar 30, 2023
c2e9d45
Add 308 status code for redirects
Fizzadar Apr 22, 2023
117f90c
Add clarification about no/false redirect param
Fizzadar May 2, 2023
bf2d22c
Add link to current spec media endpoints
Fizzadar May 2, 2023
a7733d9
Add note about additional benefit of not proxying untrusted homeserve…
Fizzadar May 2, 2023
9312cb3
Expand issues section to cover possible homeserver abuse
Fizzadar May 2, 2023
2b93616
fix a typo
anoadragon453 May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions proposals/3860-media-download-redirect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# MSC3860: Media Download Redirects
Fizzadar marked this conversation as resolved.
Show resolved Hide resolved
anoadragon453 marked this conversation as resolved.
Show resolved Hide resolved

Currently the media download endpoints must return either a 200 with content or error responses. This
means the media server instance must stream the data from wherever it is stored, which is likely not
local to itself. Allowing redirects on these endpoints would make it possible for the media repo to
tell clients/servers to pull data direct from the source, eg. a CDN.

## Proposal

This MSC simply proposes that a 307 redirect code is allowed and followed according to the `Location`
header. It is possible some clients would already follow these which needs to be confirmed. Specifc
endpoints in question:

+ `/_matrix/media/v3/download/{serverName}/{mediaId}`
+ `/_matrix/media/v3/download/{serverName}/{mediaId}/{fileName}`
+ `/_matrix/media/v3/thumbnail/{serverName}/{mediaId}`
anoadragon453 marked this conversation as resolved.
Show resolved Hide resolved

The media repo already conforms to standard HTTP practices so this may already work as expected. The
MSC is proposing to add redirects to the list of possible HTTP responses for the above endpoints in
the Matrix Specifiction. Implementation would be confirming that this works in all the major clients.