Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(beacons): expose ffi functions to start, stop and subscribe to live location shares #4578

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

torrybr
Copy link
Contributor

@torrybr torrybr commented Jan 23, 2025

FFI functions for starting ,stopping and subscribing to Live Location Shares.

Signed-off-by:

Torry Brelsford

@torrybr torrybr requested a review from a team as a code owner January 23, 2025 19:02
@torrybr torrybr requested review from jmartinesp and removed request for a team January 23, 2025 19:02
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.42%. Comparing base (2d0f873) to head (e9089c6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4578      +/-   ##
==========================================
+ Coverage   85.41%   85.42%   +0.01%     
==========================================
  Files         285      285              
  Lines       32211    32211              
==========================================
+ Hits        27512    27516       +4     
+ Misses       4699     4695       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, I think there might be an issue with unwrapping the beacon_info field, and we shouldn't cause a panic when we can't do it.

bindings/matrix-sdk-ffi/src/room.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants