Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timeline): maintain aggregations when an event is deduplicated #4576

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Jan 22, 2025

No description provided.

@bnjbvr bnjbvr force-pushed the bnjbvr/lost-reactions branch from 6c2393e to 140ab9a Compare January 23, 2025 16:58
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 90.42553% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.43%. Comparing base (4c4dd03) to head (140ab9a).

Files with missing lines Patch % Lines
crates/matrix-sdk-ui/src/timeline/event_handler.rs 86.66% 6 Missing ⚠️
...rix-sdk-ui/src/timeline/controller/aggregations.rs 89.28% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4576      +/-   ##
==========================================
+ Coverage   85.42%   85.43%   +0.01%     
==========================================
  Files         286      287       +1     
  Lines       32213    32239      +26     
==========================================
+ Hits        27517    27544      +27     
+ Misses       4696     4695       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant