Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wasm): don't kill task on drop #4572

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maan2003
Copy link
Contributor

makes behavior similar to tokio::spawn otherwise spawned tasks immediately die if join handles are not saved somewhere

@maan2003 maan2003 requested a review from a team as a code owner January 22, 2025 11:23
@maan2003 maan2003 requested review from jmartinesp and removed request for a team January 22, 2025 11:23
@maan2003
Copy link
Contributor Author

cc @jplatte

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.41%. Comparing base (991c9ad) to head (3ebe4dc).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/matrix-sdk-common/src/executor.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4572      +/-   ##
==========================================
- Coverage   85.41%   85.41%   -0.01%     
==========================================
  Files         285      285              
  Lines       32226    32232       +6     
==========================================
+ Hits        27526    27530       +4     
- Misses       4700     4702       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant