fix: Remove support for MSC3575 #4531
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
force-pushed
the
fix-remove-msc3575
branch
from
013c7d7 to
c8a3d71
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4531 +/- ##
========================================
Coverage 85.43% 85.43%
========================================
Files 285 285
Lines 32105 31960 -145
========================================
- Hits 27429 27306 -123
+ Misses 4676 4654 -22 ☔ View full report in Codecov by Sentry. |
bnjbvr
requested changes
Jan 14, 2025
| // receipt. NOTE: SS proxy workaround. | ||
| // Sliding sync sometimes sends the same event multiple times, so it can be at | ||
| // the beginning and end of a batch, for instance. In that case, just reset | ||
| // every time we see the event matching the |
| } | ||
|
|
||
| pub use msc4186::*; | ||
| pub use ruma::api::client::sync::sync_events::v5::*; |
There was a problem hiding this comment.
Can we get rid of this file now, and just use use with the ruma full path?
| /// This is useful at the moment because the current sliding sync | ||
| /// implementation uses a proxy server. | ||
| pub fn with_homeserver_override(mut self, homeserver_override: Option<String>) -> Self { | ||
| self.homeserver_override = homeserver_override; |
There was a problem hiding this comment.
The field could also be removed, right?
Comment on lines
+251
to
253
| // Sometimes sliding sync sends many duplicates of the read marker | ||
| // event. Don't forward it multiple times to avoid clutter | ||
| // the update channel. |
There was a problem hiding this comment.
We're not sure the native implementation does that, but my feeling is that we can remove this comment and keep the code as is, maybe with a much shorter comment that sounds less accusatory.
|
Yup, sure, ruma update has been extracted in #4532. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSC3575 is the “first” and “old” version of sliding sync, implemented by the sliding sync proxy and probably other homeservers. MSC4186 is the “next” and “new” version of sliding sync, being implemented inside Synapse and probably other homeservers.
The Matrix Rust SDK was supporting both versions, aiming at giving time to homeservers to transition from the experimental MSC3575 to the stable, production ready MSC4186.
It is time to say good bye to MSC3575. This is what the first patch does.
This patch also needs to update ruma (to include ruma/ruma#1995). Updating ruma involves a bit of breaking changes, it's addressed in a standalone second patch.