Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support to log in using a device code #4518

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kilimnik
Copy link

This implements the authentication via device codes. As the authentication process is similar to the QR code authentication, I used the methods provided there.

I tried my best writing the code, though I'm rather new to Rust, so I hope it's acceptable or at least not so bad that it's not fixable ;).

  • Public API changes documented in changelogs (optional)

Signed-off-by: Daniel Kilimnik [email protected]

@kilimnik kilimnik requested a review from a team as a code owner January 11, 2025 20:05
@kilimnik kilimnik requested review from poljar and removed request for a team January 11, 2025 20:05
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 89.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.44%. Comparing base (e37ad11) to head (cae409b).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...matrix-sdk/src/authentication/device_code/login.rs 88.33% 7 Missing ⚠️
...ates/matrix-sdk/src/authentication/qrcode/login.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4518      +/-   ##
==========================================
+ Coverage   85.36%   85.44%   +0.07%     
==========================================
  Files         284      285       +1     
  Lines       31886    31951      +65     
==========================================
+ Hits        27219    27299      +80     
+ Misses       4667     4652      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kilimnik kilimnik changed the title Support to log in using a device code feat: Support to log in using a device code Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant