Use the dehydrated device format implemented by vodozemac #4421
+156
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4421 +/- ##
==========================================
- Coverage 85.38% 85.36% -0.02%
==========================================
Files 284 284
Lines 31885 31893 +8
==========================================
+ Hits 27225 27227 +2
- Misses 4660 4666 +6 ☔ View full report in Codecov by Sentry. |
uhoreg
commented
Jan 4, 2025
|
Looks like the CI failures are due to ruma/ruma@cae7489 since I'm pulling in a newer version of ruma. I had fixed one instance, but other instances need to be fixed too. |
|
Since we want to avoid making breaking releases too often in Ruma, I would recommend using a branch based on the ruma-0.12 branch for now to avoid breaking changes. We will backport all non-breaking changes to it, allowing us to make patch releases whenever the SDK needs to make a release. |
Merged
|
I created #4477 to upgrade Ruma with the necessary commit from ruma/ruma#1987. |
uhoreg
force-pushed
the
dehydration_format
branch
from
7e13a1b to
b94bebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on matrix-org/vodozemac#199 and ruma/ruma#1987
Fixes #4185
Signed-off-by: