This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add a URL panel to the right panel #9586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new panel the right menu that, akin to "Files", shows all messages in the room containing at least one URL. This would help users find previously posted URLs without having to come up with the correct search term(s) to find them. Code-wise this more of a proof of concept. `UrlPanel.tsx` is almost completely copy and pasted from `FilePanel.tsx`. `UrlPanel.tsx` should probably either be stripped down or both of them should be abstracted into a generic class. Furthermore, the type of `filter` necessary for this PR does not seem to exist (the one suggested by this PR is probably quite a hack), and I am unsure what the best course of action in creating such a filter would be. Any advice on that and on how/why synapse should be involved would be appreciated. Signed-off-by: Arne Wilken [email protected]
github-actions
bot
added
the
Z-Community-PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new panel the right menu that, akin to "Files", shows all messages in the room containing at least one URL. This would help users find previously posted URLs without having to come up with the correct search term(s) to find them.
Example images:
Code-wise this more of a proof of concept.
UrlPanel.tsxis almost completely copy and pasted fromFilePanel.tsx.UrlPanel.tsxshould probably either be stripped down or both of them should be abstracted into a generic class.Furthermore, the type of
filternecessary for this PR does not seem to exist (the one suggested by this PR is probably quite a hack), and I am unsure what the best course of action in creating such a filter would be. Any advice on that and on how/why synapse must be involved would be appreciated.Related matrix-js PR for the filter: matrix-org/matrix-js-sdk#2886
Signed-off-by: Arne Wilken [email protected]
This PR currently has none of the required changelog labels.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.