Spotlight: don't join a public room when clicking on it

[florianduros]

Checklist

• Tests written for new code (and old code if feasible).
• New or updated public/exported symbols have accurate TSDoc documentation.
• Linter and other CI checks pass.
• Sign-off given on the changes (see CONTRIBUTING.md).

Closes element-hq/element-web#27523

For public room, the listener is only reacting to keyboard event for keyboard/accessibility navigation. The list element already has a button to join or preview a room for the mouse user.

[t3chguy]

This has a very bad UX right now. The hover effect + cursor pointer makes it look clickable but clicking on it does nothing, it feels broken.

[t3chguy]

Given this moves away from the designs provided to us I think we will want a design review to confirm they are happy with the new UX.

[gaelledel]

Thx - all good. To think about if we're willing to change the colour on Hover now or later.

[florianduros]

@gaelledel the colour change should be easy, I will do in the PR

[t3chguy]

Keyboard accessibility seems broken. Enter is not working to activate the tile

Screen.Recording.2024-07-05.at.08.15.51.mov

Otherwise this does what it says on the tin but I am worried about the inconsistency in the Spotlight dialog when you switch into Public rooms/spaces more. Prior the whole tile is clickable, after only the button is clickable. I feel like this inconsistency is not ideal for a11y.

[florianduros]

@t3chguy Yes, there are some inconsistencies but the short term is to fix this issue. @gaelledel and I came with this small change in order to avoid massive ux changes of the spotlight.