-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MatrixRTC: move MatrixRTCSession logic into LocalMembershipManager #4608
MatrixRTC: move MatrixRTCSession logic into LocalMembershipManager #4608
Conversation
dd398ab
to
b1fd6a3
Compare
b1fd6a3
to
f31dbf6
Compare
- myMembership related properties get moved into its own interface
… live in MyMembershipManager)
f31dbf6
to
6f119f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a few comments on the style and some naming.
Otherwise this refactor looks solid and a good step in the right direction. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes from our little pairing session:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes look good.
094b0f4
to
e31e1cb
Compare
e31e1cb
to
9daacc1
Compare
9daacc1
to
24c8eb1
Compare
Can be reviewed commit by commit.
This PR does not change the actual logic, but instead lowers the complexity of the
MatrixRTCSession
class.It moves all the logic into a new class
LocalMembershipManager
but keeps all the logic paths the same.This results in a awkward api between the manager and the session and will be tackled in a follow up PR.
Checklist
public
/exported
symbols have accurate TSDoc documentation.