Shorten TimelineWindow when an event is removed #3862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
requested changes
Nov 8, 2023
andybalaam
force-pushed
the
andybalaam/remove-event-on-window
branch
from
7114c3b to
6b40017
Compare
andybalaam
changed the title
andybalaam
changed the title
Needed for the fix for element-hq/element-web#26498
andybalaam
force-pushed
the
andybalaam/remove-event-on-window
branch
from
6b40017 to
06c7f99
Compare
t3chguy
requested changes
Nov 8, 2023
| @@ -87,6 +92,7 @@ export class TimelineWindow { | |||
| opts: IOpts = {}, | |||
| ) { | |||
| this.windowLimit = opts.windowLimit || 1000; | |||
| timelineSet.room?.on(RoomEvent.Timeline, this.onTimelineEvent.bind(this)); | |||
There was a problem hiding this comment.
This bind is superfluous, you're using an arrow function already.
There was a problem hiding this comment.
Good catch, fixed in 7242aaa . I meant to declare it without the arrow function to match the surrounding code, but failed to update it after copy-pasting from somewhere else.
t3chguy
approved these changes
Nov 9, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#26498 even when #3798 is present.
Listen for events being removed in the TimelineWIndow, and shorten the window if the removal makes it longer than the available events.
Here's what your changelog entry will look like:
🐛 Bug Fixes