Add events to the thread even if they appear to be out of order #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
requested review from
germain-gg and
florianduros
and removed request for
a team
andybalaam
force-pushed
the
andybalaam/addevent-adds-events-even-out-of-order
branch
from
d9b81b3 to
bc7faf5
Compare
andybalaam
force-pushed
the
andybalaam/addevent-adds-events-even-out-of-order
branch
from
bc7faf5 to
71bc28c
Compare
andybalaam
force-pushed
the
andybalaam/addevent-adds-events-even-out-of-order
branch
from
71bc28c to
d541ebe
Compare
andybalaam
deleted the
andybalaam/addevent-adds-events-even-out-of-order
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#26254
(hopefully)
Reduce the number of cases where we drop events that we are trying to add to a thread.
I have lots of refactorings I would like to do to addEvent but this change isolates the functional change that may address the referenced bug.
I will be holding off on merging this until after the release candidate on 17th October 2023, so that we can try it out for a couple of weeks and evaluate whether it causes more stuck notifications.
This change is marked as an internal change (Task), so will not be included in the changelog.