Adding get provider name support for chi router #569
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chi, one of the fastest and most lightweight routers for Go. When it is used for routing requests to a Gothic handler like below, Gothic fails to get the value of the 'provider' parameter.
The way to get the parameter value from a Chi request is
chi.URLParam(r, paramName)
. However, inside thegetProviderName
function of Gothic, there is no support for this extraction method.By merging this PR, it will no longer be necessary to set the provider explicitly in the context of the request to get Gothic working with the Chi router.