Support adding more complex text in ControlLabel #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miafan23
approved these changes
Apr 8, 2024
Comment on lines
35
to
+36
| /** Label text */ | ||
| text: PropTypes.string.isRequired, | ||
| text: PropTypes.oneOfType([PropTypes.string, PropTypes.node]), |
There was a problem hiding this comment.
Could you update the description Label text to tell it supports node too? now the showing type is union which is not very clear
There was a problem hiding this comment.
Oh, I didn't see your comment before I merged.. how do I update this..? It is being generated like this :(
There was a problem hiding this comment.
You mean this?
There was a problem hiding this comment.
It seems that I cannot change the "union" part, but I added more info in the text itself (I guess that's what you originally meant)
Fix is here #222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for text to be string or ReactNode