Custom select UI #218
Merged
Custom select UI #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tristen
commented
Jan 19, 2024
•
tristen
commented
- Dependent on https://github.com/mapbox/mbx-assembly/pull/68
- Closes https://mapbox.atlassian.net/browse/STUDIO-2018
AlexanderBelokon
requested changes
Jan 24, 2024
There was a problem hiding this comment.
This is a sweet component! 🔥
I only found one issue with it on the examples page: when filtering, sometimes the input loses the focus. It seems to happen every time the currently selected item is added or removed from the current list, but does not happen otherwise.
Curiously enough, it only happens in Chrome, not in Firefox 🤔
Is this a problem of the example or of the component?
filtering-focus.mov
|
@AlexanderBelokon thanks for flagging 👍 Looks like a related/possible upstream issue but I hacked a little fix for it on the demo page. |
AlexanderBelokon
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.