Introduce TypeScript and convert two components #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move a lot over to TypeScript
Adjust some files
Closed
|
Do you mind if I add .nvmrc file to your branch? Seems that it needs npm version 16 for it to work? |
| @@ -0,0 +1,25 @@ | |||
| { | |||
| "compilerOptions": { | |||
There was a problem hiding this comment.
I am complete newbie here, but from what I was reading I think we should include declaration: true, which should generate d.ts files and in package.json we should have "types" property to specify where the types should be generated. This is important for people using typescript to get autocomplete features and the actual benefits that come with using Typescript. Any thoughts on this?
There was a problem hiding this comment.
@badiuoanaalexandra I think I'm going to walk back on the commit here and add this declaration:true as its own issue to tackle in #163
This reverts commit 0b6dc34.
badiuoanaalexandra
approved these changes
Jun 30, 2022
tristen
added a commit
that referenced
this pull request
Jul 28, 2022
* Drop a lot of stuff for now and add TypeScript * Add first radix-ui piece to icon component * Move utils to TypeScript * Tests * Revert on a bunch of work This reverts commit 0b6dc34.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is large which is mostly due to the package-lock changes. There are - however - a number of files that have been affected as part of this work.
src/components/iconas a functional component and usesaccessible-iconfrom Radix as an internal primitive.src/components/control-wrapperas a functional component.src/docs/*src/components/utils/*src/components/icon/*src/components/control-wrapper/*Note I am not merging this branch into
mainbut into an[email protected]feature branch.Closes #144