Drop unmatched square bracket in Allegiance str method

makhidkarun · Nov 8, 2023 · 576c15a · 576c15a
1 parent 28e09ee
commit 576c15a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/PyRoute/Galaxy.py b/PyRoute/Galaxy.py
@@ -129,7 +129,7 @@ def set_wiki_name(name, code, base):
         names[1] = names[1].strip()
         if '' == names[0]:
             raise ValueError("First part of name string must not be an empty string itself")
-        if '' == names[1]:
+        if '' == names[1] and ',' in name:
             raise ValueError("Second part of name string must not be an empty string itself")
 
         if code.startswith('Na'):
@@ -144,7 +144,7 @@ def set_wiki_name(name, code, base):
         return '[[{}]]'.format(name)
 
     def __str__(self):
-        return '{} ([{})'.format(self.name, self.code)
+        return '{} ({})'.format(self.name, self.code)
 
     def is_unclaimed(self):
         return AllyGen.is_unclaimed(self)

diff --git a/Tests/Hypothesis/testAllegiance.py b/Tests/Hypothesis/testAllegiance.py
@@ -173,6 +173,11 @@ def test_set_wiki_name(self, name, code, base):
         assume(wiki_name is not None)
         self.assertNotIn('[]', wiki_name, "Empty square brackets not allowed in wiki name")
 
+    def test_string_representation(self):
+        alg = Allegiance("Test", "Test Allegiance Plz Ignore")
+
+        expected = 'Test Allegiance Plz Ignore (Test)'
+        self.assertEqual(expected, str(alg), "Unexpected string representation")
 
 if __name__ == '__main__':
     unittest.main()