Finding implicit this. #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpiuva
changed the title
davidpiuva
force-pushed
the
explicit
branch
3 times, most recently
from
32bce76 to
f14f8ff
Compare
davidpiuva
force-pushed
the
explicit
branch
2 times, most recently
from
098a7e6 to
2513add
Compare
| @@ -1391,6 +1420,9 @@ TypeDecl: abstract class extends Declaration { | |||
| // if the variable is static, use class scope not instance | |||
| name := vDecl isStatic() ? "This" : "this" | |||
| call setExpr(VariableAccess new(name, call token)) | |||
| if (res params explicitThis) { | |||
| call token printMessage("Implicit " + name + " detected for call to " + vDecl name + "!") | |||
There was a problem hiding this comment.
I guess that this is function calls by pointer from the table since variables are used for access.
davidpiuva
force-pushed
the
explicit
branch
2 times, most recently
from
e689e32 to
be2af46
Compare
| // add `this` if needed. | ||
| call setExpr(VariableAccess new("this", call token)) | ||
| } | ||
| // Not yet tested |
There was a problem hiding this comment.
I just have to assume that it does not give false detection until someone uses addons while not using implicit this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This style warning is optional with a compiler flag so that it can exist in both versions of rock.
Missing a few rare style errors might be acceptable to save time but false positives would bloat the output.