[DSC] Add Zimone's Hypothesis #13181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the build failed on the check, it did work on my computer and was able to test it. |
mtwilliams14
commented
Dec 26, 2024
xenohedron
requested changes
Jan 3, 2025
|
|
||
| // You may put a +1/+1 counter on a creature. | ||
| this.getSpellAbility().addEffect(new AddCountersTargetEffect(CounterType.P1P1.createInstance())); | ||
| this.getSpellAbility().addTarget(new TargetCreaturePermanent(0, 1, StaticFilters.FILTER_PERMANENT_CREATURE, true)); |
There was a problem hiding this comment.
Unfortunately, this construction doesn't work as you might hope. Despite the not-target param, it's still asking for a target on cast. Since it's not targeting, that must happen only on resolution.
What I typically see for this is a custom effect - see Titan of Industry as a reference and add a player.chooseUse to account for the "you may"
| public final class ZimonesHypothesis extends CardImpl { | ||
|
|
||
| public ZimonesHypothesis(UUID ownerId, CardSetInfo setInfo) { | ||
| super(ownerId, setInfo, new CardType[]{CardType.SORCERY}, "{3}{U}{U}"); |
There was a problem hiding this comment.
the reason for the verify failure - this card is an Instant, not a Sorcery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Zimone's Hypothesis. First time implementing a new card, but tested and it worked for me. Based most of the code off of the pre-existing Extinction Event Implementation. Additionally created new predicate for checking parity on creature power; currently only used on this card but generic enough that it could be useful in the future.