Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenAPI] Update RunResultState #37

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Conversation

mach-kernel
Copy link
Owner

Resolves #36, doing an E2E test now to make sure nothing breaks 🤞

@mach-kernel
Copy link
Owner Author

Note: The new version of openapi-generator seems to be double boxing Option:

    #[serde(rename = "git_source", default, with = "::serde_with::rust::double_option", skip_serializing_if = "Option::is_none")]
    pub git_source: Option<Option<Box<crate::models::GitSource>>>,

Turns out our use of JsonSchema would need this to use a different invocation of the derive macro: GREsau/schemars#89

But there's no need to double box them so I've edited these out. For future reference.

@mach-kernel
Copy link
Owner Author

E2E test passed, packing release up!

@mach-kernel mach-kernel merged commit b747d72 into master Nov 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unknown variant MAXIMUM_CONCURRENT_RUNS_REACHED
1 participant