Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of online docs for Fokker-Planck options #289

Merged
merged 6 commits into from
Jan 10, 2025

Conversation

mrhardman
Copy link
Collaborator

@mrhardman mrhardman commented Oct 24, 2024

PR to address #152.

To do list:

  • Go through existing functions in fokker_planck.jl and add sensible descriptions.
  • Go through existing functions in fokker_planck_calculus.jl and add sensible descriptions.
  • Go through existing functions in fokker_planck_test.jl and add sensible descriptions.
  • Go through existing functions in gauss_legendre.jl and add sensible descriptions.
  • Give overall account of solution method. EDIT - link to ExCALIBUR report given as stub.

Please add to this checklist and I will try to satisfy your documentation requests. I would prefer not to provide more online documentation of the formal method until the paper which introduces this feature is accepted, to avoid duplicated effort. I am happy to document better where steps highlighted in the existing report are carried out.

…s rather than using coord.element_scale and coord.element_shift for get_KJ_local!() matrix. Introduce initial explanatory documentation.
…ALIBUR report and giving input parameter information. Modify the index to feature this note and the note on magnetic geometry.
@mrhardman mrhardman marked this pull request as ready for review October 27, 2024 09:43
@mrhardman mrhardman added the documentation Improvements or additions to documentation label Oct 27, 2024
@johnomotani johnomotani merged commit 9196efe into master Jan 10, 2025
21 checks passed
@johnomotani johnomotani deleted the improve-fkpl-docs branch January 10, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants