Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix electron pressure evolution #287

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Conversation

johnomotani
Copy link
Collaborator

Copy the updated moments.electron.ppar into fvec_out. Previously the electron_ppar in the ion/neutral scratch_pdf struct was never updated when using the implicit electron solve (implicit_electron_ppar = true).

Previously the `electron_ppar` in the ion/neutral `scratch_pdf` struct
was never updated when using the implicit electron solve
(`implicit_electron_ppar = true`).
@johnomotani johnomotani added the bug Something isn't working label Oct 23, 2024
@johnomotani johnomotani marked this pull request as ready for review October 23, 2024 14:32
@johnomotani johnomotani force-pushed the fix-electron-pressure-evolution branch from f6f59e1 to ee6cdec Compare November 13, 2024 15:42
Updated kinetic electron test takes a bit longer, so just increase the maximum allowed time for the job.
@johnomotani johnomotani merged commit d823457 into master Nov 13, 2024
19 of 21 checks passed
@johnomotani johnomotani deleted the fix-electron-pressure-evolution branch November 13, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant