Attempt to fix intermittent CI failures #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting files in "/tmp/" on the Github Actions CI servers seems to cause occasional failures of the tests. Instead, put the test output files in subdirectories of "runs/", but only when running on the CI server - otherwise still use "/tmp/" as normal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On CI server, don't use
/tmp/for output files.I think putting files in
/tmp/on the Github Actions CI servers might be the cause of the occasional failures of the tests we've been seeing recently. Maybe the files in/tmpget cleaned out frequently, and occasionally that cleaning happens while we are still using the file? Instead, put the test output files in subdirectories ofruns/, but only when running on the CI server - otherwise still use/tmp/as normal.