Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct units for pressures to reflect normalisation used in the code. #270

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

mrhardman
Copy link
Collaborator

@mrhardman mrhardman commented Oct 1, 2024

Units for the output binary file appear to be incorrect for the pressure. Here I have corrected the units to what I understand the normalisations are.

The old normalisation for p was

$$p_{ref} = n_{ref} T_{ref}$$

the corrected normalisation is

$$p_{ref} = n_{ref} m_{ref} c_{ref}^2$$

with $c_{ref} = \sqrt{2 T_{ref}/m_{ref}}$.

@johnomotani We should also check that the normalisation reported for the heat flux is correctly documented, since the units there also reference $T_{ref}$ and not $m_{ref}c_{ref}^2$.

May close #136.

@mrhardman mrhardman added the bug Something isn't working label Oct 1, 2024
@mrhardman mrhardman requested a review from johnomotani October 1, 2024 14:06
@mrhardman mrhardman added documentation Improvements or additions to documentation and removed bug Something isn't working labels Oct 1, 2024
Copy link
Collaborator

@johnomotani johnomotani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct. I've applied a similar update to the units for heat fluxes.

@johnomotani johnomotani merged commit 8025634 into master Oct 2, 2024
21 checks passed
@johnomotani johnomotani deleted the correct_pressure_units branch October 2, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Factors of 2 in normalisation of pressure and definition of the thermal speed.
2 participants