-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to enable spitzer tests #226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollision operator only (or any diffusion operator that has no flux at vperp = 0 -- so not the numerical vperp diffusion at present -- where zero boundary conditions are imposed at vperp = L but no condition is imposed at vperp = 0. Initial short tests suggests that Maxwellian relaxation problems might run successfully without the regularity conditions -TBC.
… of existing functionality.
…serving_corrections" in the Fokker Planck input namelist.
…ng dF/dvperp = 0. Simulation shows reasonable behaviour with density preserved and thermal speed hitting a steady-state value near 0.15, which is held for multiple collision times. Ti/Talpha = 1/40 was chosen to reduce strain on resolution.
…for other parameters and no underscore being used in the examples files, so remove it in the source for consistency.
…ng without self collisions is much faster.
…pport laplacian_derivative!() for chebyshev points with direct differentiation calculation.
…especially associated with the Chebyshev pseudospectral method, which does not show good convergence even at large ngrid. The finite-element GaussLegendre method shows much better behaviour.
…tests can be executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
Er_constant
variable fromcomposition
togeometry
, to enable further similar parameters to be added togeometry
in a later PR.A separate PR from main development for ease of merging.
N.B. making the remaining input parameters reside in a namelist would likely simplify further changes of this type.