In machine_setup.sh on macOS, prompt for MPI library path #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MPIPreferences.use_system_binary() does not find the MPI library when it was installed with homebrew on macOS, so prompt for the user to give the path to the MPI library instead.
|
@johnomotani I’ll try that one out - although I’m not sure how common it is for Mac users to install MPI with homebrew, but I guess it’s still a general solution! |
|
I've added the try-catch so if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPIPreferences.use_system_binary()does not find the MPI library when it was installed with homebrew on macOS, so prompt for the user to give the path to the MPI library instead.@LucasMontoya4 does this work for you?
@mabarnes did you need to work around this problem when using the
machines/machine_setup.shsetup script?Is there a default that we should check (for non-homebrew setups?) that could find the MPI library automatically? I don't have a Mac to test...