Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pull request LM_sandbox to electrons-jto-debug #192

Merged
merged 16 commits into from
Mar 28, 2024
Merged

First pull request LM_sandbox to electrons-jto-debug #192

merged 16 commits into from
Mar 28, 2024

Conversation

LucasMontoya4
Copy link
Collaborator

No description provided.

johnomotani
johnomotani reviewed Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@johnomotani johnomotani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @LucasMontoya4! Just a couple of tiny comments to deal with 👍

examples/kinetic-electrons/wall+sheath-bc_boltzmann_loworder.toml Outdated Show resolved Hide resolved
examples/kinetic-electrons/wall+sheath-bc_boltzmann_loworder.toml Outdated Show resolved Hide resolved
examples/kinetic-electrons/wall+sheath-bc_boltzmann_loworder.toml Outdated Show resolved Hide resolved
Lucas and others added 14 commits March 19, 2024 11:14
Merge remote-tracking branch 'origin/electrons-jto-debug' into LM_san…
1d29b42 
…dbox_electrons-jto-debug
Ignoring every instance of .DS_Store, a Mac file made for folder icon…
8d8efcd 
… information and other things
@LucasMontoya4
Revert "Merge remote-tracking branch 'origin/electrons-jto-debug' int…
104496e 
…o LM_sandbox_electrons-jto-debug"

This reverts commit 1d29b42, reversing
changes made to 20ed97d.
@LucasMontoya4
"fake change I will immediately revert"
29a3e49
@LucasMontoya4
Revert ""fake change I will immediately revert""
594dd2b 
This reverts commit 29a3e49.
@LucasMontoya4
Revert "Ignoring every instance of .DS_Store, a Mac file made for fol…
713ab3f 
…der icon information and other things"

This reverts commit 8d8efcd.
@LucasMontoya4
Revert "Revert "Ignoring every instance of .DS_Store, a Mac file made…
491a205 
… for folder icon information and other things""

This reverts commit 713ab3f.
@LucasMontoya4
"remove empty line"
0668c13
@LucasMontoya4
Changes before merge reversion to avoid overwriting my local changes
b086edd
@LucasMontoya4
Revert "Revert "Merge remote-tracking branch 'origin/electrons-jto-de…
30e84cf 
…bug' into LM_sandbox_electrons-jto-debug""

This reverts commit 104496e.
@LucasMontoya4 @johnomotani
Update examples/kinetic-electrons/wall+sheath-bc_boltzmann_loworder.toml
9b6fd10 
Co-authored-by: John Omotani <[email protected]>
@LucasMontoya4 @johnomotani
Apply suggestions from code review
f7c30f9 
Co-authored-by: John Omotani <[email protected]>
@LucasMontoya4
Updated numerical dissipation functionality to enable species specifi…
aab71a2 
…c parameters
@LucasMontoya4
Merge branch 'LM_sandbox_electrons-jto-debug' of github.com:mabarnes/…
5cfab0c 
…moment_kinetics into LM_sandbox_electrons-jto-debug
johnomotani
johnomotani approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@johnomotani johnomotani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @LucasMontoya4! All neat and tidy 👍 Thanks for updating all the example input files, etc. too!

Very tiny suggestions below to make a couple of input files more consistent and fix a couple of docstrings. I'll commit those changes in a minute, and merge this.

examples/wall-bc/wall-bc_volumerecycle_split1.toml Outdated Show resolved Hide resolved
examples/wall-bc/wall-bc_volumerecycle_split2.toml Outdated Show resolved Hide resolved
moment_kinetics/src/numerical_dissipation.jl Outdated Show resolved Hide resolved
moment_kinetics/src/numerical_dissipation.jl Outdated Show resolved Hide resolved
@johnomotani johnomotani merged commit 44c914e into electrons-jto-debug Mar 28, 2024
12 of 16 checks passed
@johnomotani johnomotani deleted the LM_sandbox_electrons-jto-debug branch March 28, 2024 10:56
johnomotani pushed a commit that referenced this pull request Mar 28, 2024
@LucasMontoya4 @johnomotani
Separate dissipation parameters for ions, electrons, neutrals (#192)
115194f
@LucasMontoya4
Copy link
Collaborator Author

Thanks John! Sorry about the docstrings.. Also, I don’t know if this matters much but I changed the name of the calculate_moment_derivatives functions for each species, because the naming system was different for each. I made sure to alter the names elsewhere in the other files and I guess it must be all fine because the tests all pass?

@johnomotani
Copy link
Collaborator

I changed the name of the calculate_moment_derivatives functions for each species

I saw that, it seemed like a good idea to me - makes the names more consistent and easier to read.

johnomotani pushed a commit that referenced this pull request Apr 26, 2024
@LucasMontoya4 @johnomotani
Separate dissipation parameters for ions, electrons, neutrals (#192)
95f7ece
johnomotani pushed a commit that referenced this pull request Apr 26, 2024
@LucasMontoya4 @johnomotani
Separate dissipation parameters for ions, electrons, neutrals (#192)
910cee2
johnomotani pushed a commit that referenced this pull request Apr 26, 2024
@LucasMontoya4 @johnomotani
Separate dissipation parameters for ions, electrons, neutrals (#192)
741c20f
johnomotani pushed a commit that referenced this pull request Apr 26, 2024
@LucasMontoya4 @johnomotani
Separate dissipation parameters for ions, electrons, neutrals (#192)
1b7f4eb
johnomotani pushed a commit that referenced this pull request Apr 27, 2024
@LucasMontoya4 @johnomotani
Separate dissipation parameters for ions, electrons, neutrals (#192)
4908feb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnomotani johnomotani johnomotani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucasMontoya4 @johnomotani @mrhardman