Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HDF5 setup when separate_postproc_projects="y" #188

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

johnomotani
Copy link
Collaborator

When using separate post-processing packages and setting up makie_post_processing and/or plots_post_processing, the machine setup scripts should be editing makie_post_processing/LocalPreferences.toml and/or plots_post_processing/LocalPreferences.toml. Before this PR the top-level LocalPreferences.toml was accidentally modified, which led to the HDF5 library not being linked when using separate post-processing packages (falling back to the bundled-with-Julia HDF5, which meant parallel I/O was not available).

@johnomotani johnomotani added the bug Something isn't working label Mar 3, 2024
@johnomotani johnomotani merged commit 6effe8e into master Mar 3, 2024
16 checks passed
@johnomotani johnomotani deleted the machine-setup-hdf5-fix branch March 3, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant