Stop @loop_* ranges being altered from inside loop #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are now required, as vz and vpa are separately defined dimensions.
Read the ranges out of the `looping.loop_ranges` variable into macro-local variables at the point where `@loop_*` is called. This means that if the region type is changed (changing `looping.loop_ranges`) inside the loop, the outer `@loop_*` does not change. This behaviour is a bit at odds with how Julia behaves with nested loops, but seems more natural if you think of an `@loop_*` statement as a single thing which should not change after you enter the block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the ranges out of the
looping.loop_rangesvariable into macro-local variables at the point where@loop_*is called. This means that if the region type is changed (changinglooping.loop_ranges) inside the loop, the outer@loop_*does not change. This behaviour is a bit at odds with how Julia behaves with nested loops, but seems more natural if you think of an@loop_*statement as a single thing which should not change after you enter the block.