Fix 'longtest' CI job #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes problem where 'longtest' CI job would hang.
Avoids termination of 'longtest' CI job (which presumably happens due to running out of memory).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'longtest' job only runs when a PR is merged to
master, so we didn't see the failure before merging #150.Best guess is the failure was caused by an out-of-memory error on the Ubuntu runner - although I don't understand why that happened for the 'longtest' job which runs in serial but not for the 'parallel tests' job which does run all the 'long tests' in one of its calls!
Anyway, re-jigging to avoid loading a full 2D3V neutral distribution function into memory seems to fix the problem.