lxc-alpine: Backport fixes from the distribution maintainters #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix detecion of the alpine architecture name. This allows us to create both armv7 and armhf (armv6) containers on an aarch64 host. eg. lxc-create -t alpine a1 -- -a armv7 It also allows us to create mips64 and s390x containers, and potentially new architectures in the future.
Avoid error out if some of the device nodes exists
|
Hi, before we can review this pull request, we need all commits to be signed-off (see CONTRIBUTING). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
lxc-alpinetemplate with the fixes implemented in the version shipped by Alpine Linux, including new signing keys, support for various architectures, and a more generic fix to the issue addressed by #62.