Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add German translation #665

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Add German translation #665

merged 1 commit into from
Dec 12, 2023

Conversation

WebSnke
Copy link
Contributor

@WebSnke WebSnke commented Sep 26, 2023 •
edited
Loading

NOTE: I couldn't really test my changes but it should work since I made sure to only change the inner HTML.

@stgraber
Copy link
Member

That's not going to do anything without a STRUCTURE.de.json file

@WebSnke WebSnke marked this pull request as ready for review September 27, 2023 09:49
@WebSnke WebSnke marked this pull request as draft September 27, 2023 15:21
@WebSnke WebSnke marked this pull request as ready for review October 1, 2023 17:01
stgraber
stgraber reviewed Oct 14, 2023
View reviewed changes
content/STRUCTURE.de.json
"title": "Incus - Einführung",
"menu": ["Incus", "Einführung"],
"generator": "markdown",
"meta": {"input": "incus/introduction.de.md"}},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're referencing a bunch of .de.md files in this PR which don't exist yet, this will cause issues building the site or result in 404 for all those pages.

The reason this isn't failing right now during the build is that you didn't add German to content/CONFIG.json. Once you do, the website will actually start building the translate content and will require all referenced .de.md files to exist.

@stgraber
Copy link
Member

As expected, tests are failing due to STRUCTURE.de.JSON referencing files that don't exist.

@stgraber stgraber marked this pull request as draft November 1, 2023 02:39
@WebSnke WebSnke marked this pull request as ready for review November 27, 2023 19:22
@WebSnke WebSnke marked this pull request as draft November 27, 2023 19:23
@WebSnke
Copy link
Contributor Author

WebSnke commented Nov 27, 2023

@stgraber
Why do the workflows not start?

@stgraber
Copy link
Member

Github requires me to manually start the workflows for anyone who hasn't had code merged yet (annoyingly).

@WebSnke
Copy link
Contributor Author

WebSnke commented Dec 8, 2023

@stgraber
Okay, the tests should pass now. I think it would be more efficient to translate one-by-one, instead of trying to cram everything into one pull request.

@stgraber
Copy link
Member

stgraber commented Dec 8, 2023

Looks like you have a few commits that are missing a Signed-off-by line, other than that, the tests are looking good now!

@WebSnke
Add German translation
f098849 
Signed-off-by: Sönke Joppien <[email protected]>
@WebSnke WebSnke marked this pull request as ready for review December 12, 2023 13:44
@WebSnke
Copy link
Contributor Author

WebSnke commented Dec 12, 2023

@stgraber
I just squashed all the commits and signed them. The test should pass now.

@stgraber stgraber merged commit dd315bc into lxc:main Dec 12, 2023
6 of 7 checks passed
@stgraber
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber stgraber approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WebSnke @stgraber