Fix route.sh and some misc cleanup #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallyn
reviewed
Feb 4, 2024
|
Done.
… On Feb 4, 2024, at 2:44 PM, Serge Hallyn ***@***.***> wrote:
@hallyn commented on this pull request.
In net_route.c:
> @@ -250,6 +250,7 @@ static int handle_route_resp(int net_sock, void **out)
struct sockaddr_nl nladdr;
#ifdef TESTING
FILE *fp = NULL;
+ fp = fopen ("./route_info.txt", "w");
Should check the return value.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
anjalidk
force-pushed
the
rtfx
branch
9 times, most recently
from
df23965 to
95423a7
Compare
Fix route.sh & arp.sh and some misc cleanup Check for fp NULL, review comment by Serge. Temporary fix to remove "linkdown" from route output, because we do not handle it in net_route.c yet. This will allow route.sh to succeed. Signed-off-by: Anjali Kulkarni <[email protected]>
|
Note in general I heavily disapprove of commit messages which say "#fixes". Each logical change should be documented. |
|
On Feb 5, 2024, at 2:15 PM, Serge Hallyn ***@***.***> wrote:
Note in general I heavily disapprove of commit messages which say "#fixes". Each logical change should be documented.
Ok, will do.
… —
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.