incusd/device/disk: Better handle partitions #1578
Open
+38
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our disk I/O limits logic was assuming that the disk block device major/minor could be derived from the partition major/minor. This may still be true on some block device drivers, but in general now, it's common to have a single major shared by multiple drives, making this logic lead to the incorrect device. Instead we now keep track of partitions when scanning block devices and maintain a map from the partition major/minor back to its parent disk. Signed-off-by: Stéphane Graber <[email protected]> Sponsored-by: https://webdock.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our disk I/O limits logic was assuming that the disk block device major/minor could be derived from the partition major/minor.
This may still be true on some block device drivers, but in general now, it's common to have a single major shared by multiple drives, making this logic lead to the incorrect device.
Instead we now keep track of partitions when scanning block devices and maintain a map from the partition major/minor back to its parent disk.
Sponsored-by: https://webdock.io