Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new config hook #1577

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add new config hook #1577

wants to merge 12 commits into from
+859 −538

Conversation

bensmrs
Copy link
Contributor

@bensmrs bensmrs commented Jan 16, 2025

Closes #1400

@bensmrs bensmrs requested a review from stgraber as a code owner January 16, 2025 18:19
@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Jan 16, 2025
@bensmrs
Copy link
Contributor Author

bensmrs commented Jan 16, 2025

And obviously I forgot to fix the tests :)

@bensmrs bensmrs force-pushed the qemu-scriptlet-config branch from 1159c52 to 1a431a4 Compare January 16, 2025 20:20
@bensmrs
Copy link
Contributor Author

bensmrs commented Jan 16, 2025

Phew that linter is very conservative!

bensmrs added 11 commits January 16, 2025 20:55
@bensmrs
incusd/instance: Pass an *api.Instance to the scriptlet program
7e66700 
Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs
incusd/scriptlet/qemu: Add instance parameter to the QEMU scriptlet
ec4ee7f 
Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs
incusd/instance: Rewire QEMU config generation
688bb41 
Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs
incusd/instance: Make QEMU config types public
9168da5 
Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs
incusd/scriptlet/qemu: Fix Starlark function name
34626c5 
Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs
incusd/scriptlet/qemu: Prevent calling QMP functions at config stage
12f0e8a 
Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs
incusd/scriptlet/qemu: Add QEMU configuration getters
8e67486 
Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs
incusd/scriptlet/qemu: Add QEMU configuration setters
89ff277 
Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs
api: qemu_scriptlet_config
58fbe94 
Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs
doc/ref/instance_options: Update QEMU scriptlet documentation
1718bc4 
Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs
incusd/instance: Update unit test
a85a512 
Signed-off-by: Benjamin Somers <[email protected]>
@bensmrs bensmrs force-pushed the qemu-scriptlet-config branch from 1a431a4 to a85a512 Compare January 16, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber Awaiting requested review from stgraber stgraber is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
API Changes to the REST API Documentation Documentation needs updating
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow QEMU scriptlets to read VM structs and edit QEMU config
1 participant
@bensmrs