Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd v256 seems to require overriding ImportCredential= for all containers #850

Merged
merged 1 commit into from
May 24, 2024

Conversation

gibmat
Copy link
Contributor

@gibmat gibmat commented May 23, 2024

After #849, privileged Debian sid containers with systemd v256~rc3 work fine, but unprivileged ones don't. Adding the ImportCredential= override for them as well finally makes all my sid containers happy again.

@stgraber
Copy link
Member

Unpriv sid containers have been working fine here, so long as you have apparmor 4.0 and so get the new apparmor rule, otherwise you need to use security.nesting=true to allow all mounts.

@gibmat
Copy link
Contributor Author

gibmat commented May 24, 2024

Does setting security.nesting=true for unprivileged containers have any other implications/consequences? It's going to be a while before apparmor 4.0 becomes widely available (and some users, such as people running Incus on bookworm hosts will never see it). If that extra step becomes necessary as newer versions of systemd are used in containers, it seems like that will cause confusion for users who expect incus launch images:.... to work out of the box with its defaults.

Are there concerns about overriding ImportCredential= for services in unprivileged containers?

@stgraber stgraber merged commit cc2b72f into lxc:main May 24, 2024
8 checks passed
@stgraber
Copy link
Member

Probably no real concerns. I'm sure the systemd devs won't like us turning all their security features, but apparmor is a mess so we don't have too much choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants