address #305

lucidrains · Dec 23, 2024 · 003275c · 003275c
1 parent cdf51f7
commit 003275c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/setup.py b/setup.py
@@ -3,7 +3,7 @@
 setup(
   name = 'x-transformers',
   packages = find_packages(exclude=['examples']),
-  version = '1.43.1',
+  version = '1.43.2',
   license='MIT',
   description = 'X-Transformers - Pytorch',
   author = 'Phil Wang',

diff --git a/tests/test_x_transformers.py b/tests/test_x_transformers.py
@@ -409,7 +409,8 @@ def test_custom_alibi(flash: bool):
 
     logits = model(x, pos = pos)
 
-def test_custom_rotary_pos_emb():
+@pytest.mark.parametrize('rotary_xpos', (True, False))
+def test_custom_rotary_pos_emb(rotary_xpos):
     from einops import repeat
 
     model = TransformerWrapper(
@@ -419,7 +420,8 @@ def test_custom_rotary_pos_emb():
             dim = 512,
             depth = 2,
             heads = 8,
-            rotary_pos_emb = True
+            rotary_pos_emb = True,
+            rotary_xpos = rotary_xpos
         )
     )
 

diff --git a/x_transformers/x_transformers.py b/x_transformers/x_transformers.py
@@ -666,7 +666,7 @@ def forward(self, t):
             return freqs, 1.
 
         power = (t - (max_pos // 2)) / self.scale_base
-        scale = self.scale ** rearrange(power, 'n -> n 1')
+        scale = self.scale ** rearrange(power, '... n -> ... n 1')
         scale = torch.stack((scale, scale), dim = -1)
         scale = rearrange(scale, '... d r -> ... (d r)')