Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/opsim 1104 #43

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Tickets/opsim 1104 #43

merged 3 commits into from
Jan 23, 2024

Conversation

yoachim
Copy link
Member

@yoachim yoachim commented Jan 11, 2024

Example of Survey sub-class for when one want to use a list of discrete pointings.

@yoachim yoachim requested a review from ehneilsen January 11, 2024 18:34
Copy link
Contributor

@ehneilsen ehneilsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't too bad to figure out by looking at the code, but a sentence or two explicitly stating what sequences are and how they are encoded in note might require less thought from the reader.

@yoachim yoachim merged commit 65f689f into main Jan 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants