Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-34340: implement RFC-834 deprecations #903

Merged
merged 16 commits into from
Nov 22, 2023

Add, use DataCoordinate.make_empty.

4d005f7
Select commit
Loading
Failed to load commit list.
Merged

DM-34340: implement RFC-834 deprecations #903

Add, use DataCoordinate.make_empty.
4d005f7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 21, 2023 in 0s

87.45% (-0.27%) compared to f22234c

View this Pull Request on Codecov

87.45% (-0.27%) compared to f22234c

Details

Codecov Report

Attention: 198 lines in your changes are missing coverage. Please review.

Comparison is base (f22234c) 87.72% compared to head (4d005f7) 87.45%.

Files Patch % Lines
...daf/butler/dimensions/_data_coordinate_iterable.py 44.04% 31 Missing and 16 partials ⚠️
python/lsst/daf/butler/dimensions/_graph.py 66.03% 34 Missing and 2 partials ⚠️
python/lsst/daf/butler/dimensions/_coordinate.py 87.11% 21 Missing and 8 partials ⚠️
python/lsst/daf/butler/dimensions/_group.py 90.50% 13 Missing and 4 partials ⚠️
python/lsst/daf/butler/_dataset_type.py 48.00% 9 Missing and 4 partials ⚠️
python/lsst/daf/butler/dimensions/_universe.py 87.50% 6 Missing and 1 partial ⚠️
python/lsst/daf/butler/registry/sql_registry.py 66.66% 5 Missing and 1 partial ⚠️
...ython/lsst/daf/butler/registry/queries/_structs.py 76.19% 3 Missing and 2 partials ⚠️
python/lsst/daf/butler/_named.py 75.00% 4 Missing ⚠️
python/lsst/daf/butler/dimensions/_packer.py 63.63% 3 Missing and 1 partial ⚠️
... and 12 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #903      +/-   ##
==========================================
- Coverage   87.72%   87.45%   -0.27%     
==========================================
  Files         285      286       +1     
  Lines       36760    37144     +384     
  Branches     7698     7828     +130     
==========================================
+ Hits        32246    32485     +239     
- Misses       3341     3474     +133     
- Partials     1173     1185      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov